ascent icon indicating copy to clipboard operation
ascent copied to clipboard

rajafy merge

Open cyrush opened this issue 3 years ago • 3 comments

cyrush avatar Jun 03 '22 17:06 cyrush

array_min and array_max now have a different return type

(it's the form of value_position (instead of value) but not tagged as such)

This is causing a few tests to fail, but also flipping result to value reveals value_position is expected in some places. Working on figuring this out.

cyrush avatar Jun 07 '22 23:06 cyrush

value_position is used for value and vector position in space.

Not a good fit for array_max, array_min outputs.

I kept their extra outputs values (index, count,etc) for internal use.

cyrush avatar Jun 13 '22 18:06 cyrush

using with cmake fixes:

  • [x] Need a fix for VTK-h headers (amalga case)
  Imported target "ascent::ascent" includes non-existent path

    "/__w/1/s/install/include/ascent/vtkh"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

  • [x] Need fix for raja linked in imported targets.
[100%] Linking CXX executable ascent_render_example
/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/cmake-3.21.1-oa6z6yp7omgoygmhqy5rwygm3igefbjo/bin/cmake -E cmake_link_script CMakeFiles/ascent_render_example.dir/link.txt --verbose=1
/usr/bin/mpicxx CMakeFiles/ascent_render_example.dir/ascent_render_example.cpp.o -o ascent_render_example  -Wl,-rpath,/__w/1/s/install/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/python-3.8.11-tfx2yhhpco7hidielgc73wiwuetlxsde/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/occa-1.2.0-djxfgmhs5kselxwuhpaljxpffxuubjiq/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/umpire-6.0.0-enb3qv3z3wl2o6gafihxs53wclmjfctm/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/conduit-0.8.2-hmiufumdidfvzh4cvleb7wysgj7ilzi4/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/hdf5-1.8.22-etdel7g4i3odqnnxtia5inbm2a7no6th/lib:/uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/zlib-1.2.11-m5jouz3oa44jqndzortxqmnpxdh2d66g/lib /__w/1/s/install/lib/libascent.so /__w/1/s/install/lib/libascent_flow.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/python-3.8.11-tfx2yhhpco7hidielgc73wiwuetlxsde/lib/libpython3.8.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/occa-1.2.0-djxfgmhs5kselxwuhpaljxpffxuubjiq/lib/libocca.so -lRAJA /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/umpire-6.0.0-enb3qv3z3wl2o6gafihxs53wclmjfctm/lib/libumpire.so /__w/1/s/install/lib/librover.so /__w/1/s/install/lib/libvtkh_rendering.so /__w/1/s/install/lib/libvtkh_filters.so /__w/1/s/install/lib/libvtkh_compositing.so /__w/1/s/install/lib/libvtkh_core.so /__w/1/s/install/lib/libvtkh_utils.so /__w/1/s/install/lib/libascent_lodepng.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_rendering-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_filter_extra-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_filter_contour-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_filter_gradient-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_filter_common-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_worklet-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_io-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_cont-1.7.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkmdiympi_nompi.a /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/vtk-m-1.7.1-tcfne5stut7z7qvkhkofk46y2mnaczyp/lib/libvtkm_lodepng-1.7.a /usr/lib/gcc/x86_64-linux-gnu/10/libgomp.so /usr/lib/x86_64-linux-gnu/libpthread.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/conduit-0.8.2-hmiufumdidfvzh4cvleb7wysgj7ilzi4/lib/libconduit_relay.so -lpthread -lrt /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/hdf5-1.8.22-etdel7g4i3odqnnxtia5inbm2a7no6th/lib/libhdf5.so.10.4.0 -lm -ldl /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/zlib-1.2.11-m5jouz3oa44jqndzortxqmnpxdh2d66g/lib/libz.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/conduit-0.8.2-hmiufumdidfvzh4cvleb7wysgj7ilzi4/lib/libconduit_blueprint.so /uberenv_libs/spack/opt/spack/linux-ubuntu21.04-zen2/gcc-10.3.0/conduit-0.8.2-hmiufumdidfvzh4cvleb7wysgj7ilzi4/lib/libconduit.so 
/usr/bin/ld: cannot find -lRAJA

cyrush avatar Jun 16 '22 01:06 cyrush

We are green :-)

cyrush avatar Nov 09 '22 21:11 cyrush

ran hip tests, verified expressions infra is using hip.

cyrush avatar Nov 23 '22 00:11 cyrush

nice. Thanks for getting this over the finish line.

mclarsen avatar Nov 28 '22 22:11 mclarsen

@mclarsen happy to get this in!

cyrush avatar Nov 28 '22 22:11 cyrush