alpha-wallet-ios icon indicating copy to clipboard operation
alpha-wallet-ios copied to clipboard

Updating resolving token script attributes with Combine publisher

Open oa-s opened this issue 2 years ago • 1 comments

suggestion topic: Updating resolving token script attributes with Combine publisher.

Currenty we updated Subscribable with current value subject to fit it to curr implemetation, accessing .value for resolved value. we use syncAsync for resolving a value on each step. cons of doing that is we capturing object that actually causes memory leaks, its especially visible when we change rpc Server, tons of objects stays captured.

Could replacing with AnyPublisher help us to resolve this issue, so we would subscribe for resolving attrubutes on caller side, and would be able to cancel it when needed

just have no idea what we can do for fixing memory leaks here.

@hboon any thoughts?

oa-s avatar Mar 03 '23 08:03 oa-s

@oa-s can you help make a very contrived function/class that we can call from a button push to reproduce the way it's used and how it leaks when we switch chains? Include as little other code as possible? Might be easier to tell.

hboon avatar Mar 05 '23 02:03 hboon