alpha-wallet-ios icon indicating copy to clipboard operation
alpha-wallet-ios copied to clipboard

Floor price is often 0.0000 ETH for NFTs sourced from OpenSea

Open hboon opened this issue 3 years ago • 7 comments

Could be rate limit? But the other data show up.

Screenshot 2022-04-28 at 11 00 37 PM

hboon avatar Apr 28 '22 15:04 hboon

Yes, that is because of rate limited

oa-s avatar Apr 29 '22 09:04 oa-s

@oa-s but the other data in this screen always show up, or are they stored separately? If they are stored, can they be stored together?

hboon avatar Apr 29 '22 15:04 hboon

there was a problem with passing its value bettwen screens, so when this screen opens, we make a new request to fetch price again

oa-s avatar May 03 '22 05:05 oa-s

In that case, can we store it together with the rest of the token's data, in the balance JSON.

hboon avatar May 04 '22 05:05 hboon

the problem with this issue is that there is separate requests needed to get stats. When we loading assets list, it contains stats for each asset, also we need to send one more request to get collection stats. And that might cause trottle issue

oa-s avatar Jun 29 '22 05:06 oa-s

Ok, let's leave this for a bit, we might change how it works with #4918

hboon avatar Jun 29 '22 05:06 hboon

ok, got it

oa-s avatar Jun 29 '22 07:06 oa-s