Umbrella issue for using token mapping

[hboon]

trafficstars

• Use token icon from iconassets for mapped tokens
  • [x] Implement overlaying the smaller chain icon over the icon sourced from iconassets (is this only for those that are in token maps or every token in Wallet tab?) #3542 https://github.com/AlphaWallet/alpha-wallet-android/issues/2294
  • [x] Update iconassets to remove chain icon overlay from every icon that has them #3545
  • [ ] Use the same/one copy of token icon in https://github.com/AlphaWallet/iconassets for mapped tokens on the same/different chains. i.e. Display the same token icon for native token on Ethereum and WETH on Ethereum and WETH on Polygon, etc. if WETH doesn't have an icon available #3636
  • [x] Switch app to read from master of iconassets again as described in https://github.com/AlphaWallet/alpha-wallet-ios/pull/3627#issue-812919069
• Groups
  • [x] Manually populate group in mapping for each token map #3549
  • [x] Design UI for using group in token map #3546
  • [x] Implement UI to display hardcoded group (not from mapping) #3580 https://github.com/AlphaWallet/alpha-wallet-android/issues/2282
  • [x] Read and display groups read from token map #3546 #3581

More:

• [ ] Use price tickers (if available) for mapped tokens #3423
• [ ] Hide spam tokens #4020

[colourfreak]

First usage: A network icon in a corner of each token

So we have this small network icon in the bottom left corner of each token.

https://zpl.io/aB3X98k

It's 16x16.

This is an example:

And this is our goal:

Network icons: https://zpl.io/agE1LeZ

[colourfreak]

Second usage The token symbol is only uploaded once and reused if there is the same token on a different network.

That means that I can remove all uploads from iconassets that were related to BSC, Polygon, Heco, etc. and upload only one token icon without any network icon in a corner (Mainnet Ethereum).

[hboon]

@JamesSmartCell umbrella issue

[colourfreak]

@hboon Can you go ahead and make an order with current iconsets? Let's chat about it on Discord.

[hboon]

Sure, let's chat. But what do you mean by "make an order with current iconsets" ?

[colourfreak]

Sure, let's chat. But what do you mean by "make an order with current iconsets" ?

So currently all BSC, Heco, Polygon tokens uploaded to iconassets (sorry, missed this with iconsets) have this small network icon already there. It might look weird sometimes if we have this network icon inside a graphical file and as another layer.

Example: https://github.com/AlphaWallet/iconassets/blob/master/0x2170Ed0880ac9A755fd29B2688956BD959F933F8/logo.png

[hboon]

@colourfreak ok. Let me think a bit about what’s the easiest way to do this. Will get back to you tomorrow. Feel free to update the icons locally first, but don’t upload yet.

[hboon]

Here's how I suggest we do it.

Tomek:

1. Download the entire iconassets repo by going to https://github.com/AlphaWallet/iconassets, click the green Code button, Download ZIP.
2. Modify the relevant icon files to remove the chain overlay
3. Zip it up, send it to Boon
4. Also update the native token icons (e.g Ethereum) to remove the chain overlays. These are bundled with the apps.

Boon:

5. Create a single commit based on the updated image files to update the iconassets repo based on the updated zip

Boon and James

6. Update the app to overlay the chain icons for both icons from iconsassets repo and those embedded in the app
7. Ship updated apps

I had thought to do this in a proper way because doing it like above will result in a window between 5 and 7 where the icons from iconassets don't have their chain overlay, but I think it's too slow and we are dragging it out, so let's just get it done.

How does that sound @colourfreak?

[colourfreak]

Sounds good. I am on it. @hboon

[hboon]

@colourfreak sorry, one more (on mobile). The little chain icons to bundle with the app. Not sure we already have them in the app.

[colourfreak]

Network icons: https://zpl.io/agE1LeZ

This one?

[hboon]

This one?

@colourfreak yes. Thanks.

[colourfreak]

iconassets-master.zip

@hboon

[hboon]

@colourfreak got it. Thanks!