alpha-wallet-android icon indicating copy to clipboard operation
alpha-wallet-android copied to clipboard

feat: initial implementation of TS viewContent & URL fragment.

Open micwallace opened this issue 3 years ago β€’ 3 comments

  • Add view content processing, to inject common view content when a view is loaded.
  • Add URL hash/fragment location when loading the view.

micwallace avatar Sep 22 '22 14:09 micwallace

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
πŸ₯‡
10
β–€β–€β–€β–€β–€
11h 30m
β–€β–€β–€β–€β–€β–€β–€β–€β–€
13
β–€β–€β–€β–€β–€
seabornlee
πŸ₯ˆ
9
β–€β–€β–€β–€β–€
37m
β–€
11
β–€β–€β–€β–€β–€

github-actions[bot] avatar Sep 22 '22 14:09 github-actions[bot]

@JamesSmartCell Good news, CDATA is working in Android :-)

micwallace avatar Sep 22 '22 14:09 micwallace

  • Add view content processing, to inject common view content when a view is loaded. ...

@micwallace would you help write a description/issue so iOS can implement it for feature parity?

hboon avatar Sep 22 '22 14:09 hboon

Hey @hboon ,

I've got to focus on Devcon stuff for most of this week, but there is some preliminary information here: https://github.com/TokenScript/tokenscript-cli/pull/9

It basically allows 2 or more cards to share the same javascript/html/css.

micwallace avatar Sep 26 '22 05:09 micwallace

@micwallace There is a test case failure, can you check it out? image

seabornlee avatar Sep 27 '22 08:09 seabornlee

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Files Coverage Ξ”
.../alphawallet/app/ui/widget/holder/EventHolder.java 0.00% <0.00%> (ΓΈ)
...phawallet/app/ui/widget/holder/TransferHolder.java 0.00% <0.00%> (ΓΈ)
...lphawallet/app/service/AssetDefinitionService.java 4.43% <0.00%> (+<0.01%) :arrow_up:
.../java/com/alphawallet/app/ui/FunctionActivity.java 0.00% <0.00%> (ΓΈ)

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Sep 25 '23 04:09 codecov[bot]