alpha-wallet-android icon indicating copy to clipboard operation
alpha-wallet-android copied to clipboard

feat: allow copy of NFT contract address from NFTAssetDetailActivity

Open micwallace opened this issue 2 years ago β€’ 2 comments

Pretty much what the title says. This is nice to have as a developer :-)

micwallace avatar Sep 22 '22 14:09 micwallace

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
JamesSmartCell
πŸ₯‡
10
β–€β–€β–€β–€β–€
11h 30m
β–€β–€β–€β–€β–€β–€β–€β–€β–€
13
β–€β–€β–€β–€β–€
seabornlee
πŸ₯ˆ
9
β–€β–€β–€β–€β–€
37m
β–€
11
β–€β–€β–€β–€β–€

github-actions[bot] avatar Sep 22 '22 14:09 github-actions[bot]

Codecov Report

Base: 7.47% // Head: 7.47% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (ea2acc3) compared to base (1e6494a). Patch coverage: 0.00% of modified lines in pull request are covered.

:exclamation: Current head ea2acc3 differs from pull request most recent head 38df588. Consider uploading reports for the commit 38df588 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #2840      +/-   ##
===========================================
- Coverage      7.47%   7.47%   -0.01%     
+ Complexity      804     790      -14     
===========================================
  Files           597     579      -18     
  Lines         41413   40803     -610     
  Branches       4226    4165      -61     
===========================================
- Hits           3097    3048      -49     
+ Misses        38050   37491     -559     
+ Partials        266     264       -2     
Impacted Files Coverage Ξ”
...com/alphawallet/app/ui/NFTAssetDetailActivity.java 0.00% <0.00%> (ΓΈ)
...java/com/alphawallet/app/widget/TokenInfoView.java 0.00% <0.00%> (ΓΈ)
...in/java/com/alphawallet/app/util/BalanceUtils.java 18.84% <0.00%> (-2.18%) :arrow_down:
...lphawallet/app/repository/EthereumNetworkBase.java 51.92% <0.00%> (-1.67%) :arrow_down:
...lphawallet/app/viewmodel/NewSettingsViewModel.java 29.41% <0.00%> (-0.78%) :arrow_down:
...n/java/com/alphawallet/app/entity/Transaction.java 6.89% <0.00%> (-0.27%) :arrow_down:
app/src/main/java/com/alphawallet/app/C.java 57.14% <0.00%> (ΓΈ)
.../main/java/com/alphawallet/app/ui/NFTActivity.java 0.00% <0.00%> (ΓΈ)
...main/java/com/alphawallet/app/ui/SwapActivity.java 0.00% <0.00%> (ΓΈ)
.../java/com/alphawallet/app/service/SwapService.java 0.00% <0.00%> (ΓΈ)
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 22 '22 14:09 codecov[bot]

Modifications done:

  • TokenInfoView can now set any text to become copyable via .setCopyableValue(String text)
  • Copyable text now displays an icon
  • Replaced copy action from long-click to regular click

justindg avatar Oct 28 '22 05:10 justindg

Preview:

image

justindg avatar Oct 28 '22 05:10 justindg