alpha-wallet-android
alpha-wallet-android copied to clipboard
2319 wallet connect v2 sign typed data v4
Close #2319 Close #2153
Test Dapp: https://react-app.walletconnect.com
Test wallet seed phrase:
essence allow crisp figure tired task melt honey reduce planet twenty rookie
Tasks:
- [x] i18n
- [x] Scan
- [x] Approve
- [x] Reject
- [x] View sessions
- [x] Disconnect
- [x] Multiple Chains
- [x] Multiple wallets
- [x] Watch only wallet
- [x] Wallet not found (Paired and then deleted)
- [x] Show session on home
- [x] Show notification
- [x] UI/UX
- [x] Connect from Dapp browser
- [x] Call methods from Dapp
- [x] eth_personalSign
- [x] eth_signTypedData
- [x] eth_sendTransaction
- [x] eth_signTransaction
- [x] eth_sign(standard)
- [x] eth_signTypedData v4
- [x] Network not activated
@justindg Dark mode is awesome! Can you help adopt dark mode for the notification on the homepage?
You can use https://react-app.walletconnect.com/ to test.
@justindg Dark mode is awesome! Can you help adopt dark mode for the notification on the homepage ?
You can use https://react-app.walletconnect.com/ to test.
I finished it already. @justindg
Codecov Report
Merging #2445 (5e7c70e) into master (61e48a9) will increase coverage by
0.08%
. The diff coverage is3.42%
.
:exclamation: Current head 5e7c70e differs from pull request most recent head 2d1f276. Consider uploading reports for the commit 2d1f276 to get more accurate results
@@ Coverage Diff @@
## master #2445 +/- ##
===========================================
+ Coverage 2.15% 2.24% +0.08%
- Complexity 246 262 +16
===========================================
Files 552 576 +24
Lines 39852 40774 +922
Branches 4060 4114 +54
===========================================
+ Hits 859 914 +55
- Misses 38922 39789 +867
Partials 71 71
Impacted Files | Coverage Δ | |
---|---|---|
app/src/main/java/com/alphawallet/app/App.java | 0.00% <0.00%> (ø) |
|
app/src/main/java/com/alphawallet/app/C.java | 0.00% <ø> (ø) |
|
.../main/java/com/alphawallet/app/di/ToolsModule.java | 0.00% <0.00%> (ø) |
|
...c/main/java/com/alphawallet/app/entity/Wallet.java | 23.21% <0.00%> (-0.43%) |
:arrow_down: |
...llet/app/entity/walletconnect/NamespaceParser.java | 0.00% <0.00%> (ø) |
|
...entity/walletconnect/WalletConnectSessionItem.java | 0.00% <0.00%> (ø) |
|
...tity/walletconnect/WalletConnectV2SessionItem.java | 0.00% <0.00%> (ø) |
|
...lphawallet/app/interact/WalletConnectInteract.java | 0.00% <0.00%> (ø) |
|
...om/alphawallet/app/service/PriceAlertsService.java | 0.00% <ø> (ø) |
|
.../alphawallet/app/service/WalletConnectService.java | 0.00% <0.00%> (ø) |
|
... and 53 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 61e48a9...2d1f276. Read the comment docs.