alpha-wallet-android icon indicating copy to clipboard operation
alpha-wallet-android copied to clipboard

Hide "Renew" and "Records" actions inside ENS token

Open colourfreak opened this issue 4 years ago • 7 comments

They are not working, so it's better if we hide these functionalities for now, till we have this fixed one day. So please make just one button, "Transfer".

Stays like this for 15 minutes already and no change. 2021-09-13 09 23 17


Temporary, new design Screenshot 2021-09-13 at 09 28 59

@hboon I think this is what we should do with all not-working features. Hide them for now.

colourfreak avatar Sep 13 '21 15:09 colourfreak

@colourfreak yes. If they don’t work or not work well enough, we should hide or remove them.

hboon avatar Sep 13 '21 16:09 hboon

This is a TokenScript issue - does the script now fail?

JamesSmartCell avatar Sep 13 '21 23:09 JamesSmartCell

@JamesSmartCell so what to do with that - just add check for the Renew option and disable that by hardcode?

mpaschenko avatar Sep 29 '21 07:09 mpaschenko

I will have a look at the script see if it's easy to update. I have to renew my ENS soon anyway, and had a small involvement with the design of this script.

JamesSmartCell avatar Oct 05 '21 12:10 JamesSmartCell

I will have a look at the script see if it's easy to update. I have to renew my ENS soon anyway, and had a small involvement with the design of this script.

Ideally with activity related to these transactions. I mean, let's aim for the best possible feature. So for example when I set ENS avatar, it was unclear looking at Activity what I have just did.

Example: https://github.com/AlphaWallet/alpha-wallet-ios/issues/3278#issuecomment-940931777

colourfreak avatar Oct 12 '21 11:10 colourfreak

Example: AlphaWallet/alpha-wallet-ios#3278 (comment)

I like this flow much better.

FWIW, I think that activity page you currently get to when you click the activityview item was primarily intended for TokenScript enabled transactions that have the expanded activity text / graphics. I'll post an example when I can find one.

But, it doesn't need to be there for anything other than a TokenScript transaction that has an expanded view.

JamesSmartCell avatar Oct 18 '21 01:10 JamesSmartCell

@JamesSmartCell feel free to tweak the screens, but generally let's not waste time on the Activities tab for now. It's important but a time sinker in the short term unless we devote ourselves to improving it significantly (and we will).

hboon avatar Oct 18 '21 02:10 hboon