Abdulaziz Aloqeely

Results 105 comments of Abdulaziz Aloqeely

I agree with your suggested fix, but this option's deprecation will be enforced so it will be removed from the docs in the next release anyway.

You're right. I agree on removing it

Similar to what I said in #58488, not sure if this is worth fixing considering there's already a PR working on removing this parameter in #58280 We could fix this...

It seems like `convert_dtypes` does not do any conversion if the existing dtypes are already supporting pd.NA. This might be intended because originally the point of `convert_dtypes` was to encourage...

@mroeschke don't you think the doc is incorrect though? It says it converts columns to the best possible dtypes that support pd.NA but that is not actually the case, if...

Hey, the pre-commit code checks are actually passing, the problem here is that some of the unit tests are failing See this guide for running the unit tests locally: https://pandas.pydata.org/docs/dev/development/contributing_codebase.html#running-the-test-suite

I have not had enough time to look at this, but from the issue title, shouldn't you `await` this to remove the warning: ```python tasks = {db_reader.read_sql_async(sql, params=p) for p...

I agree this should work, trying this on a series works as expected: ```python ser = pd.Series(['1', '2', '3', '4'], dtype='int32') ``` As for the error message, it says "Trying...

This is indeed fixed on main. @mroeschke what are your thoughts on this and #58644? And if a backport is appropriate then should we change the whatsnew entry from a...

Thanks for the report! I agree the behavior of addition and multiplication should be consistent. Addition and multiplication are commutative so `a + b` should be equal to `b +...