JetBrains-Discord-Integration icon indicating copy to clipboard operation
JetBrains-Discord-Integration copied to clipboard

Fix rich presence timing issue

Open entrypointkr opened this issue 2 years ago • 4 comments

I had some investigation, even this plugin tries restart every 20 seconds, discord-rpc reconnection time is 60 seconds. Therfore, this is a minimal changes to make discord-rpc properly work.

Fixes #223

entrypointkr avatar Apr 15 '22 06:04 entrypointkr

will this ever be merged?

JasonLovesDoggo avatar Aug 11 '22 21:08 JasonLovesDoggo

Sorry, forgot about this when working on the last release. That being said I don't really see the reason for this change.

discord-rpc reconnection time is 60 seconds

This isn't really true at all, it says it right above the linked line. discord-rpc starts at a delay of 500ms and goes up to 60 seconds when repeatedly trying to reconnect, it doesn't just start at 60 seconds. Ideally the plugin would use an exponential backoff as well, but I don't see how just changing the delay to 60 seconds solves anything

Almighty-Alpaca avatar Aug 27 '22 14:08 Almighty-Alpaca

@Almighty-Alpaca The rpc reconn time seems reset when try reconnect earlier. If I start the plugin without Discord, then the rpc reconnection time will gets longer than the plugin reconn time, after that we can’t never get connection using current 20 seconds. Then, how about get 1 to 120 seconds exponential backoff instead?

entrypointkr avatar Aug 27 '22 16:08 entrypointkr

@Almighty-Alpaca ^^

JasonLovesDoggo avatar Feb 26 '23 20:02 JasonLovesDoggo