AREPL-vscode icon indicating copy to clipboard operation
AREPL-vscode copied to clipboard

Replace renderjson

Open ZainlessBrombie opened this issue 6 years ago • 10 comments

The renderjson library is extremely simplistic and the external dependency is causing only issues, imo. I'll see that I'll rewrite it, with support for long lists and big numbers. At the time of writing this, the project is not compiling so I need to wait for that :)

ZainlessBrombie avatar May 23 '19 22:05 ZainlessBrombie

#219 #238 #176 #172 Yes that issue basically already exists: #97 oops

ZainlessBrombie avatar May 23 '19 22:05 ZainlessBrombie

When you say the project is not compiling do you mean arepl-vscode?

Almenon avatar May 24 '19 02:05 Almenon

@Almenon yes, I'll copy the message I sent you on reddit:

Hey there! :)

You invited me to contribute to AREPL recently, but I've pulled the repo and it is not running. The multi type array [type1, ...any[]] is used (available ts 3.x) but the package.json is at 2.x. Also, another piece of code works only in ts 3.0.1, because there was a breaking change in 3.1 that lets You no longer use boolean operators on void, we might want to upgrade to the newest version, it shouldn't need much adjustment. There is also line 7 in src/env/types.ts which references ./application/commands, which does not exist (probably not commited?). Could You, in a seperate directory, check out the repository and do a clean install and build to see what is missing?

Thanks! :)

ZainlessBrombie avatar May 24 '19 04:05 ZainlessBrombie

I'll get on that, thanks for letting me know.

Almenon avatar May 24 '19 04:05 Almenon

damn you're right, I've been using the wrong typescript version.

https://i.imgur.com/S4Hccg6.png

Almenon avatar May 24 '19 04:05 Almenon

:see_no_evil:

ZainlessBrombie avatar May 24 '19 05:05 ZainlessBrombie

backend compilation is also failing, leme fix that too.

Almenon avatar May 24 '19 05:05 Almenon

@ZainlessBrombie done, both repos should work out-of-box now :)

Almenon avatar May 24 '19 05:05 Almenon

@Almenon Lovely! I'm at work rn but I'll see that I get started doing some stuff :) This is the sixth project I have in parallel so I need to mange resources a little, but I'll see that I can get some decent chunks :+1:

ZainlessBrombie avatar May 24 '19 07:05 ZainlessBrombie

BTW big number support would be implemented outside of renderjson, in the handling of the response from the python code or in the python code itself.

Almenon avatar May 25 '19 05:05 Almenon