alluxio icon indicating copy to clipboard operation
alluxio copied to clipboard

[WIP] Create ASF

Open LuQQiu opened this issue 2 years ago • 3 comments

What changes are proposed in this pull request?

Please outline the changes and how this PR fixes the issue.

Why are the changes needed?

Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

LuQQiu avatar Sep 20 '22 15:09 LuQQiu

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • Title must be at least 2 words
      • First word of title ("ASF") is not an imperative verb. Please use one of the valid words

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

alluxio-bot avatar Sep 20 '22 15:09 alluxio-bot

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

All checks passed!

alluxio-bot avatar Sep 20 '22 15:09 alluxio-bot

Error: 6.107 [ERROR] alluxio.client.file.MetadataCachingBaseFileSystemTest.getBlockLocations Time elapsed: 0.003 s <<< FAILURE! java.lang.AssertionError: expected:<1> but was:<2>

LuQQiu avatar Sep 20 '22 23:09 LuQQiu

@LuQQiu Thank you for bring this great feature!

I wonder whether we should copy all of the lib/-underfs-.jar to the client side?

maobaolong avatar Sep 23 '22 01:09 maobaolong

wait for https://github.com/Alluxio/alluxio/pull/16184/files

LuQQiu avatar Sep 23 '22 18:09 LuQQiu

@LuQQiu Thank you for bring this great feature!

I wonder whether we should copy all of the lib/-underfs-.jar to the client side?

haven't decided yet, u can only copy the needed UFSes

LuQQiu avatar Sep 23 '22 18:09 LuQQiu

Cherry-picked commit of https://github.com/Alluxio/alluxio/pull/16184 to unblock asf pr

LuQQiu avatar Sep 26 '22 15:09 LuQQiu

@apc999 @yyongycy This PR will focus on the read path first. Write path with object storage e.g. S3 will have the following issues that need to be resolved:

  • S3/object storage eventual consistency issue
  • Lacking some of the metadata information that Fuse relies on e.g. File is completed or not

LuQQiu avatar Sep 29 '22 18:09 LuQQiu

Alluxio S3 UFS does not support setMode() (also set owner group) causing

$ cp ../LICENSE .                                                                                                                  ok
cp: ../LICENSE: could not copy extended attributes to ./LICENSE: Permission denied
2022-09-30 10:45:15,759 DEBUG AlluxioJniFuseFileSystem - Enter: Fuse.Chmod(path=/LICENSE,mode=100000)
2022-09-30 10:45:15,767 DEBUG AlluxioJniFuseFileSystem - Exit (0): Fuse.Chmod(path=/LICENSE,mode=100000) in 8 ms
2022-09-30 10:45:15,767 DEBUG AlluxioJniFuseFileSystem - Enter: Fuse.Getattr(path=/LICENSE)
2022-09-30 10:45:16,053 DEBUG AlluxioJniFuseFileSystem - Exit (0): Fuse.Getattr(path=/LICENSE) in 286 ms

For S3fs-fuse, they add customized metadata to S3 objects (e.g. "x-amz-meta-mode"]) and then check permission on the client side.

This requires us to modify S3 UFS to support set mode/owner/group by setting special S3 metadata

LuQQiu avatar Sep 30 '22 18:09 LuQQiu

Moved to https://github.com/Alluxio/alluxio/pull/16284

LuQQiu avatar Oct 10 '22 15:10 LuQQiu