alluxio
alluxio copied to clipboard
Alluxio
[WIP] Add a command to decommission a specific worker
What changes are proposed in this pull request?
A new command to decommission a single worker.
Why are the changes needed?
https://github.com/Alluxio/alluxio/issues/15343 https://github.com/Alluxio/alluxio/pull/14000
Thanks for PR 14000, we want to give a more detailed version.
Does this PR introduce any user facing changes?
Yes, I'll add them in the future.
Please list the user-facing changes introduced by your change, including
- change in user-facing APIs
- addition or removal of property keys
- webui
Thank you for your pull request. In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA). It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]
It looks like this PR has some duplication with the #15949 and #15956，Can you take a look and give some advice?
Thanks for advice of @qian0817😁👍! Today I have no time to modify more codes, I will deal with your comments this morning.
@dbw9580 @YichuanSun PTAL there's another existing PR with a similar ask (but not identical): https://github.com/Alluxio/alluxio/pull/15155 Just wanted to make sure we don't end up having multiple commands with overlapping functionality.
After rerethinking😅, I think the reboot method in AlluxioWorkerProcess is not thread-safe definitely, I'll correct it.
Is there design doc for this feature, for some of the implemented code I don't understand why.
Is there design doc for this feature, for some of the implemented code I don't understand why.
https://docs.google.com/document/d/1GDVghn_9AOViOoSDvt1sqR8tSdyUmZ6D8xKN9YmhRu0/edit#