alluxio icon indicating copy to clipboard operation
alluxio copied to clipboard

Published 20 hours ago • verified publisher icon Alluxio

[WIP] Add a command to decommission a specific worker

Open YichuanSun opened this issue 2 years ago • 4 comments

What changes are proposed in this pull request?

A new command to decommission a single worker.

Why are the changes needed?

https://github.com/Alluxio/alluxio/issues/15343 https://github.com/Alluxio/alluxio/pull/14000

Thanks for PR 14000, we want to give a more detailed version.

Does this PR introduce any user facing changes?

Yes, I'll add them in the future.

Please list the user-facing changes introduced by your change, including

  1. change in user-facing APIs
  2. addition or removal of property keys
  3. webui

YichuanSun avatar Sep 01 '22 14:09 YichuanSun

Thank you for your pull request. In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA). It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]

alluxio-bot avatar Sep 01 '22 14:09 alluxio-bot

It looks like this PR has some duplication with the #15949 and #15956，Can you take a look and give some advice?

qian0817 avatar Sep 02 '22 01:09 qian0817

Thanks for advice of @qian0817😁👍! Today I have no time to modify more codes, I will deal with your comments this morning.

YichuanSun avatar Sep 02 '22 16:09 YichuanSun

@dbw9580 @YichuanSun PTAL there's another existing PR with a similar ask (but not identical): https://github.com/Alluxio/alluxio/pull/15155 Just wanted to make sure we don't end up having multiple commands with overlapping functionality.

jiacheliu3 avatar Sep 03 '22 13:09 jiacheliu3

After rerethinking😅, I think the reboot method in AlluxioWorkerProcess is not thread-safe definitely, I'll correct it.

YichuanSun avatar Oct 11 '22 01:10 YichuanSun

Is there design doc for this feature, for some of the implemented code I don't understand why.

qian0817 avatar Oct 13 '22 11:10 qian0817

Is there design doc for this feature, for some of the implemented code I don't understand why.

https://docs.google.com/document/d/1GDVghn_9AOViOoSDvt1sqR8tSdyUmZ6D8xKN9YmhRu0/edit#

YichuanSun avatar Oct 17 '22 08:10 YichuanSun

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 10 '23 15:02 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

Do not stale it, I will improve this feature in the future.

YichuanSun avatar Feb 12 '23 07:02 YichuanSun

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 14 '23 15:03 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 16 '23 15:06 github-actions[bot]