alluxio
alluxio copied to clipboard
Alluxio
Optimize getFileBlockLocations performance
What changes are proposed in this pull request?
optimize getFileBlockLocations performance.
Why are the changes needed?
reduce a useless getStatus RPC when get the file block locations.
Does this PR introduce any user facing changes?
No user facing changes.
Automated checks report:
- Commits associated with Github account: PASS
- PR title follows the conventions: FAIL
- The title of the PR does not pass all the checks. Please fix the following issues:
- First word must be capitalized
- The title of the PR does not pass all the checks. Please fix the following issues:
Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.
Automated checks report:
- Commits associated with Github account: PASS
- PR title follows the conventions: PASS
All checks passed!
Also can you do a rebase since it has been a while since you put up the PR. Thanks!
Also can you do a rebase since it has been a while since you put up the PR. Thanks!
I don't see any conflicts with the master branch, and as far as I know there are no changes that would have an impact in the meantime. I don't understand why rebase is needed.
Also can you do a rebase since it has been a while since you put up the PR. Thanks!
I don't see any conflicts with the master branch, and as far as I know there are no changes that would have an impact in the meantime. I don't understand why rebase is needed.
For example, just an example, the signature of a method you newly called in your PR has changed: fun(a) -> fun(a,b). You are still using fun(a) in your PR but the signature has been changed to f(a,b). In that case, there won't be a explicit merge conflict but your code won't able to build after you merge.
Btw i did a second pass of the review. Thanks for the comments they make sense. Just left a couple of minor comments. Can you address them and do a rebase? Thanks a lot!
Also can you do a rebase since it has been a while since you put up the PR. Thanks!
I don't see any conflicts with the master branch, and as far as I know there are no changes that would have an impact in the meantime. I don't understand why rebase is needed.
For example, just an example, the signature of a method you newly called in your PR has changed: fun(a) -> fun(a,b). You are still using fun(a) in your PR but the signature has been changed to f(a,b). In that case, there won't be a explicit merge conflict but your code won't able to build after you merge.
Btw i did a second pass of the review. Thanks for the comments they make sense. Just left a couple of minor comments. Can you address them and do a rebase? Thanks a lot!
got it.
