alluxio
alluxio copied to clipboard
Alluxio
Set FREE as the default action when file's ttl is expired
Hi all,
May I get reviews for this small patch?
What changes are proposed in this pull request?
When file's ttl is expired, the default action performs on it was changed from DELETE to FREE.
Why are the changes needed?
This is because the file may be used again even though the file's ttl is expired. So it seems better to free it instead of deleting it.
Does this PR introduce any user facing changes?
No.
Thanks. Best regards, Jie
Thank you for your pull request. In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA). It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]
The TTL in Alluxio is used for a strict access pattern(TTL is disabled by default and should only be enabled by clients which have strict data access patterns.), I don't think we should change the default value in this case.
@HelloHorizon Not sure some people would set the alluxio.user.file.create.ttl without set xx.action, the result maybe not as expected, the file could be deleted without any conform, so is it would be better if we change the default value to free or do nothing?
I prefer not to change the default behavior. At this moment there are users who rely on this feature to manage the life cycle of their data.
I prefer not to change the default behavior. At this moment there are users who rely on this feature to manage the life cycle of their data.
If not considering backward compatibility, I would say FREE is a better default. @HelloHorizon Do we know roughly which users are relying on the default DELETE action?
I prefer not to change the default behavior. At this moment there are users who rely on this feature to manage the life cycle of their data.
If not considering backward compatibility, I would say FREE is a better default. @HelloHorizon Do we know roughly which users are relying on the default DELETE action?
People in the US use this function to meet GDPR requirements.
@maobaolong @DamonFool Since we have backward compatibility promises to fulfill, we will not change the default TTL action from DELETE to FREE. So you will need to manually configure the action to be FREE whenever you configure the TTL. Please let me know if you have any concerns, thanks!
Closing this PR due to the discussion above. We will keep the default action for TTL. Thank you all for the contribution and I look forward to your other PRs :)
FYI we have recently changed the default to FREE https://github.com/Alluxio/alluxio/pull/16823 Hope this helps :)