alluxio icon indicating copy to clipboard operation
alluxio copied to clipboard

Published 20 hours ago • verified publisher icon Alluxio

Add MountTableTrie in MountTable to reduce time complexity

Open bobbai00 opened this issue 2 years ago • 10 comments

What changes are proposed in this pull request?

Based on the issue 15266, I implemented TrieNode<T> and MountTableTrie which can speed up the search in MountTable. After MountTableTrie is enabled, we can avoid iterate over all entries in MountTable and compare their literals, and traverse from the root TrieNode to the target TrieNode and only compare the inode id saved in each TrieNode instead.

Also, I implemented MountTableBench based on the newly-added Microbenchmark framework and verified the efficiency MounTableTrie has brought.

Why are the changes needed?

It will expedite MountTable methods and other methods that frequently use MountTable greatly. See the MountTable Microbench Report for more details

Does this PR introduce any user facing changes?

Nope.

bobbai00 avatar May 18 '22 07:05 bobbai00

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("Using") is not an imperative verb. Please use one of the valid words
      • Supported title prefixes are: [WIP], [SMALLFIX], [DOCFIX]

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

alluxio-bot avatar May 18 '22 07:05 alluxio-bot

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

All checks passed!

alluxio-bot avatar May 22 '22 01:05 alluxio-bot

The failed test is because of the issue #16328.

bobbai00 avatar Oct 16 '22 21:10 bobbai00

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 30 '23 15:01 github-actions[bot]

Many hdfs client scenarios do not require mount info. Maybe we can skip it. https://github.com/Alluxio/alluxio/pull/15578

flaming-archer avatar Feb 23 '23 09:02 flaming-archer

@bobbai00 are you still working on it? @jiacheliu3 should we close this one?

elega avatar Mar 02 '23 05:03 elega

@bobbai00 are you still working on it? @jiacheliu3 should we close this one?

Hi, I haven't worked on it for a well.

bobbai00 avatar Mar 02 '23 06:03 bobbai00

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 23 '23 15:04 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 15 '23 15:06 github-actions[bot]