alluxio icon indicating copy to clipboard operation
alluxio copied to clipboard

Make worker block lock pool size observable

Open elega opened this issue 2 years ago • 8 comments

What changes are proposed in this pull request?

This PR implements a block lock resource pool for workers with more logs and metrics added.

Why are the changes needed?

The pool size should be observable by metric and logging, so we know when this pool is full.

Does this PR introduce any user facing changes?

N/A

Implemented #14803

elega avatar Mar 30 '22 13:03 elega

Hi @elega, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

alluxio-bot avatar Mar 30 '22 13:03 alluxio-bot

Automated checks report:

  • Commits associated with Github account: FAIL
    • It looks like your commits can't be linked to a valid Github account. Your commits are made with the email [email protected], which does not allow your contribution to be tracked by Github. See this link for possible reasons this might be happening. To change the author email address that your most recent commit was made under, you can run:
      git -c user.name="Name" -c user.email="Email" commit --amend --reset-author
      
      See this answer for more details about how to change commit email addresses. Once the author email address has been updated, update the pull request by running:
      git push --force https://github.com/elega/alluxio.git true-worker-block-lock-pool
      
  • PR title follows the conventions: PASS

Some checks failed. Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks.

alluxio-bot avatar Mar 30 '22 13:03 alluxio-bot

Automated checks report:

  • Commits associated with Github account: PASS
  • PR title follows the conventions: PASS

All checks passed!

alluxio-bot avatar Mar 30 '22 13:03 alluxio-bot

@beinan Can you take a look?

HelloHorizon avatar Mar 30 '22 17:03 HelloHorizon

@beinan hi thanks for reviewing my first PR on alluxio. I addressed some of your comments and replied the rest. Would you mind taking a look when you have time? Thanks a lot!

elega avatar Mar 31 '22 12:03 elega

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jan 29 '23 15:01 github-actions[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 15 '23 15:06 github-actions[bot]