allsky icon indicating copy to clipboard operation
allsky copied to clipboard

Only allow latitude and longitude values with N, S, E, or W.

Open EricClaeys opened this issue 1 year ago • 1 comments

Only allow latitude and longitude values with N, S, E, or W.

sunwait and the Allsky Website require the latitude and longitude to have N, S, E, or W in them. We should only allow that format and during upgrades install.sh should convert any +/- formatted numbers to N/S/E/W format. We could then remove the code that converts formats and modify the code that checks for bogus values to include +/- as bogus.

Don't allow bogus lat and long values

For example, 12.34.56 The entered value must be a valid decimal number <= 180 (?). Make sure documentation is clear.

EricClaeys avatar Nov 28 '24 08:11 EricClaeys

@Alex-developer, after giving this some more thought, I think we should continue allowing either a number or N,S,E,W to be entered, but convert whatever the user enters into N,S,E,W and save that in the settings file. If we convert, we should notify the user as an FYI.

Thoughts?

EricClaeys avatar Dec 27 '24 00:12 EricClaeys