Alexander Stecher

Results 229 comments of Alexander Stecher

Yeah you are right, I also realized it wasn't properly maintained after seeing that the `exclude` filter was just broken on linux, which is a bummer since you built a...

If we are going the cgo route, I would definitely prefer `e-dant/watcher` because of fanotify and it generally feels more up-to-date. A custom de-bounce was already necessary for `fswatch` and...

`e-dant/watcher` is now built in in the bookworm images (still have to do alpine + cleanup). It works great 👍 , `fanotify` allows me to watch a big vendor folder...

What still needs to happen before this PR is finished: - [x] install `edant/watcher` so it works in arm - [x] [this](https://github.com/e-dant/watcher/pull/51) if we decide to stick with the meson...

While it would be nice to have a download, I don't think it's necessary since we're running the pipelines here for all the supported environments anyways.

@dunglas is there a trick to make the static build work with libraries that depend on `libstdc++`? (like `edant/watcher`) I've tried as a shared and a static library but it...

`msan` seems to be complaining about [an uninitialized value in the watcher itself with infotiy](https://github.com/dunglas/frankenphp/actions/runs/10881243892/job/30189758294?pr=1013#step:13:9622) I'm not sure if this is legit or by design since I'm not very familiar...

Are you talking about [this Runner.php](https://github.com/php-runtime/frankenphp-symfony/blob/main/src/Runner.php)? It looks like the runtime is somehow not executing correctly or maybe your Kernel doesn't implement the Terminable Interface, I think it should though...

Zap does have a [WithLazy](https://github.com/uber-go/zap/blob/5786471c1d41c255c1d8b63ad30a82b68eda2c21/logger.go#L189-L209), but it will not immediately capture the request and instead keep a reference to it for later. Which means the request might be mutated at...

Using `WithLazy` for the error logger in `server.go` actually boosts requests/second in the 'Hellow World' case by another ~10%., But when actual errors are logged, the request at the time...