SnowflakeNet icon indicating copy to clipboard operation
SnowflakeNet copied to clipboard

Published 20 hours ago • verified publisher icon AllenXiangX

Accidental use of PCN test data for validation?

Open lucasbrynte opened this issue 2 years ago • 1 comments

Hi!

I just wanted to report what I think might be a mistake in using the PCN test data not only for testing, but also for validation. Shouldn't utils.data_loaders.DatasetSubset.TEST in the following rather be utils.data_loaders.DatasetSubset.VAL..? https://github.com/AllenXiangX/SnowflakeNet/blob/93e7151610765e7e2b41ace2d03c8750f0b6c80c/core/train_pcn.py#L36-L37

Regards, Lucas

lucasbrynte avatar Dec 07 '22 13:12 lucasbrynte

Hi, Thank you for your interest in our work. To have a fair comparisn with previous work on the PCN benchmark, the model is trained on the training set and validated on the test set as most previous work does.

AllenXiangX avatar Dec 08 '22 03:12 AllenXiangX