AllenSDK icon indicating copy to clipboard operation
AllenSDK copied to clipboard

consistent naming of change column across tables

Open matchings opened this issue 4 years ago • 2 comments

Describe the bug There is a column present in multiple tables in the Visual Behavior behavior_ophys_experiment class with a Boolean indicating whether a stimulus was a change or not, however this column named different things in the different tables. In the stimulus_presentations table, it is called is_change and in the trials table it is called stimulus_change.

To Reproduce image

Expected behavior The column should be renamed to change in both tables

matchings avatar Aug 06 '21 21:08 matchings

@matchings the convention for this type of field is to prefix with "is". I'm going to keep the name in the presentations table the same and rename the field in the trials table to be the same

aamster avatar Jul 18 '22 14:07 aamster

@aamster sounds good, thanks. That’s probably least distributive to users as well since most people use the stimulus table more frequently than the trials table.

matchings avatar Jul 18 '22 15:07 matchings