giu icon indicating copy to clipboard operation
giu copied to clipboard

[bug] Multiple fonts / Icon fonts broken since migration

Open Geo5 opened this issue 2 years ago • 3 comments

Hey, using icon fonts (and also possibly the MultipleFonts example) seems to be broken since the migration to cimgui-go.

Below is the code example, which correctly displays icons on v0.7.0 but does not work on current master: Fonts_v0 7 0 Fonts_master

The minimal example uses https://github.com/juliettef/IconFontCppHeaders with forkawesome-webfont.ttf

I could not find any changes, which seemed meaningful to me to FontAtlasProcessor.go since v0.7.0, so maybe it has something to do with cimgui-go itself.

Code example

main.go
package main

import (
	iconFonts "github.com/juliettef/IconFontCppHeaders"

	g "github.com/AllenDang/giu"
)

var IconFont = iconFonts.IconsForkAwesome

func Icon(name string) string {
	ret, ok := IconFont.Icons[name]
	if !ok {
		panic(name + " icon not found")
	}
	return ret
}

func loop() {
	g.SingleWindow().Layout(
		g.Label("Content line"),
		g.Label("Content line "+Icon("Check")),
		g.Button("Normal button"),
		g.Button("Normal button"+Icon("Check")),
	)
}

func main() {
	wnd := g.NewMasterWindow("Multiple fonts and icons", 600, 400, g.MasterWindowFlagsNotResizable)
	// Change the default font to include icons
	g.Context.FontAtlas.SetDefaultFont("forkawesome-webfont.ttf", 20)
	wnd.Run(loop)
}

To Reproduce

  1. Run the demo on master
  2. Run the demo on v0.7.0

Version

master

OS

Linux

Geo5 avatar Oct 08 '23 01:10 Geo5

GlyphRangesBuilder is broken. Refer https://github.com/AllenDang/cimgui-go/issues/206

gucio321 avatar Oct 23 '23 11:10 gucio321

upstream issue closed, @Geo5 there was a large change in the way how cimgui-go wraps imgui types. Could you check if this works now?

gucio321 avatar Feb 17 '24 14:02 gucio321

It does not seem to fix anything image

Geo5 avatar Feb 20 '24 20:02 Geo5