PlayerLeaveEvent issue being in a postfix

Open whichtwix opened this issue 6 months ago • 5 comments

Currently the PlayerLeaveEvent is in a postfix which means the @event.clientdata.character is null from the game destroying it. Could we get a before/after leave event or just change it to be prefix?

Jul 13 '25 07:07 whichtwix

Maybe also make the before event cancellable? or can that lead to abuse on the devs' end? up for debate but I just thought I'd put this idea here

Jul 13 '25 10:07 WanderingPix

it cant be cancelled you cant control dcs from internet lol

Jul 13 '25 10:07 whichtwix

oh, I thought it was triggered on ExitGameButton.OnClick()

Jul 13 '25 10:07 WanderingPix

thats just 1 possible reason, theres an enum

Jul 13 '25 10:07 whichtwix

make a PR i'll review it

Aug 05 '25 01:08 XtraCube