OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

i18n : Add Arabic

Open anthonyyoussef01 opened this issue 1 year ago • 8 comments

  • add ar translation

anthonyyoussef01 avatar Apr 10 '24 20:04 anthonyyoussef01

Arabic will need a full handling of the RTL layout.

It not a simple text translation.

seuros avatar Apr 10 '24 20:04 seuros

@seuros is this PR better than nothing? Or should we close it until we have LTR support?

rbren avatar Apr 10 '24 21:04 rbren

image it looks fine

anthonyyoussef01 avatar Apr 10 '24 21:04 anthonyyoussef01

@anthonyyoussef01: It doesn't look fine, Arabic/Hebrew should start from the right side and the html should be dir='rtl'

Does the bot respond to/in Arabic ?

@rbren I believe it's essential to properly implement (RTL) support if OpenDevin is to support it and there is genuine interest.

Additionally, the text in question is classical Arabic, primarily used in news and literature, whereas each country and region has its own dialect.

I have seen a lot open-source projects with RTL strings that appear visually horribly in the end.

Although I think internationalization might be beneficial in the future, I suggest that the core team should pause the addition of new languages until OpenDevin reaches a stable version.

Or there is an active features contributor that wants to support their native language.

seuros avatar Apr 10 '24 21:04 seuros

It seems like mostly native speakers contributing their language. I like the idea of crowdsourcing i18n, so I'm inclined to accept those PRs as they come.

@anthonyyoussef01 are you a native Arabic speaker? Is it hard to add rtl support in addition to this change?

rbren avatar Apr 12 '24 08:04 rbren

It seems like mostly native speakers contributing their language. I like the idea of crowdsourcing i18n, so I'm inclined to accept those PRs as they come.

@anthonyyoussef01 are you a native Arabic speaker? Is it hard to add rtl support in addition to this change?

I am. I can try to update this pr with rtl support

anthonyyoussef01 avatar Apr 12 '24 13:04 anthonyyoussef01

@neubig @rbren Is this good?

anthonyyoussef01 avatar Apr 14 '24 23:04 anthonyyoussef01

@anthonyyoussef01 looks good! Just need to fix the linter and the merge conflict

rbren avatar Apr 15 '24 12:04 rbren