OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

[BUG FIX] Remove usage of mapProvider and supporting tests due to undesired int…

Open wi-ski opened this issue 6 months ago • 1 comments

  • [ ] This change is worth documenting at https://docs.all-hands.dev/
  • [x] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.

Fixes an issue where the model provider selection (e.g., Vertex AI) in the HeroUI autocomplete component did not correctly persist the selected value. Previously, typing and selecting an option would submit an invalid provider identifier (e.g., missing underscores), causing LightLLM to fail during startup. This change ensures that the selected value is accurately saved and used, eliminating hidden UI mismatches and improving reliability when configuring providers.

Video recording: https://www.loom.com/share/7a95d9fd23e246e7ab44376ab3bf4783?sid=e3ab1673-f86b-4c3d-88bb-a35e97208040

Relevant Herou UI Links: https://github.com/heroui-inc/heroui/issues/3353 https://github.com/heroui-inc/heroui/pull/3375#issuecomment-2491442193


Summarize what the PR does, explaining any non-trivial design decisions.

Removes usage of mapProvider and associated tests from the frontend.


Link of any specific issues this addresses: Resolves #8689

wi-ski avatar Jun 07 '25 00:06 wi-ski

Following up on this - repeating the wins:

  1. Reduced code footprint
  2. Reduced complexity
  3. Increased future proof-ness.
  4. Better Reflects underlying behavior

Cost: Loss of a pretty label.

wi-ski avatar Jun 09 '25 14:06 wi-ski

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 28 '25 02:07 github-actions[bot]

This PR was closed because it has been stalled for over 30 days with no activity.

github-actions[bot] avatar Aug 04 '25 02:08 github-actions[bot]