OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

Use python3.11 as default

Open SmartManoj opened this issue 1 year ago • 8 comments

Will use python3.11 as default for now as there are no wheels for chroma-hnswlib for 3.12

When should you upgrade to Python 3.12?

Solves #879

SmartManoj avatar Apr 08 '24 05:04 SmartManoj

This change also helps for someone using Ubuntu 22.04 within WSL. In that environment, python 3.10 is the system default and you have to manually install python3.11

If we merge this PR, then there'd be no need to prefix make build with POETRY_VIRTUALENVS_PREFER_ACTIVE_PYTHON=true as mentioned https://github.com/python-poetry/poetry/issues/7158#issuecomment-1342197929

lowlyocean avatar Apr 08 '24 17:04 lowlyocean

It looks like 3.12 support is trickling through the dependency stream. onnxruntime just added support, which should get pulled in by chromadb

https://github.com/microsoft/onnxruntime/issues/17842

In the meantime, maybe we can adjust the Makefile to ensure that windows users are using exactly 3.11? That way Linux users don't have to downgrade

rbren avatar Apr 12 '24 02:04 rbren

just added

They did on Feb 10 itself (2 months over) https://github.com/microsoft/onnxruntime/issues/17842#issuecomment-1936484800

SmartManoj avatar Apr 12 '24 02:04 SmartManoj

Actually it looks like Chroma did too? https://github.com/chroma-core/chroma/pull/1715

There's been a release since that merge too, 0.4.24 on 2/27

rbren avatar Apr 12 '24 08:04 rbren

Maybe we need to open an issue here? https://github.com/chroma-core/hnswlib

Regardless--rather than downgrading to 3.11 for everyone, if we want to make a change here we should just downgrade for windows users. Shouldn't bee too hard to add here

OOC--does this affect WSL users?

rbren avatar Apr 12 '24 08:04 rbren

FYI, the OS in #879 is Mac.

SmartManoj avatar Apr 12 '24 08:04 SmartManoj

Yeah seeing that now. We also have https://github.com/OpenDevin/OpenDevin/issues/1007

Seems like maybe we do need this...

rbren avatar Apr 12 '24 09:04 rbren

Let's get this in. If it creates problems, it'll just be for devs at this point 😄

rbren avatar Apr 16 '24 14:04 rbren

Kept waiting for the tests to pass and realized you removed 3.12 😂

Removed the requirement for those

rbren avatar Apr 17 '24 17:04 rbren