OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

chore(frontend): Remove making a query to the balance API to check for a 402 error

Open amanape opened this issue 7 months ago • 3 comments

  • [ ] This change is worth documenting at https://docs.all-hands.dev/
  • [ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces. This was introduced in #7098, I don't remember why, most likely a mistake


Summarize what the PR does, explaining any non-trivial design decisions.


Link of any specific issues this addresses:


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:81f013c-nikolaik   --name openhands-app-81f013c   docker.all-hands.dev/all-hands-ai/openhands:81f013c

amanape avatar May 16 '25 15:05 amanape

@amanape can you describe more why we need this?

rbren avatar May 16 '25 15:05 rbren

It's more of a "why we don't need this", it didn't make sense to call the balance query in the home screen, let alone to use it to check for 402s

It adds a source of confusion in our logs since it makes it look like the user was making a balance-related query when they were just in the home screen

amanape avatar May 16 '25 15:05 amanape

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 16 '25 02:06 github-actions[bot]

This PR was closed because it has been stalled for over 30 days with no activity.

github-actions[bot] avatar Jun 23 '25 02:06 github-actions[bot]