[Bug]: OpenHands crashes on non-ascii chars (🙁)

[rex-remind101]

Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).

• [x] I have checked the existing issues.

Describe the bug and reproduction steps

I asked OpenHands to refactor some ruby .erb code. Code in question has a frowny-face char 🙁. OpenHands took it too seriously and sadly crashed:

RequestHTTPError: Server error ‘500 Internal Server Error’ for url ‘http://host.docker.internal:34274/execute_action’ For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/500 
Details: Traceback (most recent call last): File “/openhands/code/openhands/runtime/action_execution_server.py”, line 629, in execute_action observation = await client.run_action(action) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File “/openhands/code/openhands/runtime/action_execution_server.py”, line 303, in run_action observation = await getattr(self, action_type)(action) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File “/openhands/code/openhands/runtime/action_execution_server.py”, line 477, in edit result_str, (old_content, new_content) = _execute_file_editor( ^^^^^^^^^^^^^^^^^^^^^
File “/openhands/code/openhands/runtime/action_execution_server.py”, line 114, in _execute_file_editor result = editor( ^^^^^^^
File “/openhands/poetry/openhands-ai-5O4_aCHf-py3.12/lib/python3.12/site-packages/openhands_aci/editor/editor.py”, line 129, in __call__ return self.insert(_path, insert_line, new_str, enable_linting) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File “/openhands/poetry/openhands-ai-5O4_aCHf-py3.12/lib/python3.12/site-packages/openhands_aci/editor/encoding.py”, line 113, in wrapper return method(self, path, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File “/openhands/poetry/openhands-ai-5O4_aCHf-py3.12/lib/python3.12/site-packages/openhands_aci/editor/editor.py”, line 417, in insert temp_file.write(line + ‘\n’) File “/openhands/micromamba/envs/openhands/lib/python3.12/tempfile.py”, line 499, in func_wrapper return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: ‘ascii’ codec can’t encode character ‘\U0001f641’ in position 39: ordinal not in range(128)

(note i added newlines to the output for readability but originally it was all in 1 single line)

looks like it's trying to encode unicode as ascii for some reason. Relevant code seems to be around here

OpenHands Installation

Docker command in README

OpenHands Version

No response

Operating System

MacOS

Logs, Errors, Screenshots, and Additional Context

No response

[enyst]

I seem to recall we recently fixed some emoji... 🤔 Cc: @ryanhoangt what do you think of this?

[ryanhoangt]

Yeah I think this should be fixed in https://github.com/All-Hands-AI/openhands-aci/pull/99 🤔 @rex-remind101 would you mind sharing the content of the .erb file that crashed the editor? That'd be helpful for me to repro this. Thanks!

[rex-remind101]

code is proprietary, but here's a snippet out of the 300+ line erb with some words changed

<div id="selector">
  <div class="selector redacted redacted-icons">
    <%# a big comment a big comment a big comment a big comment a big comment a big comment a big comment a big comment a big comment%>
    <% (MyClass::VALID_EMOJI - ['🙁']).each do |emo| %>
      <span class="<%= emo %>"><i class="<%= emo %>"></i></span>
    <% end %>
  </div>
</div>

[ryanhoangt]

Hmm this is weird, I just tested an insert using the ACI for a file with the content above and it seems to work fine... Just to make sure, what were the OpenHands version that you used when encoutering the error?

[rex-remind101]

looks like 0.32.0, there's a couple new versions now it looks like so i'll upgrade, but from what i can tell that's later than the pr #99 you posted

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[mamoodi]

Keeping this open because I don't think it's resolved?

[github-actions[bot]]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions[bot]]

This issue was closed because it has been stalled for over 30 days with no activity.