OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

[Bug]: Resolver does not seem to be aware of line numbers when addressing PR review comments

Open Tim-Pohlmann opened this issue 8 months ago • 4 comments

Is there an existing issue for the same bug? (If one exists, thumbs up or comment on the issue instead).

  • [x] I have checked the existing issues.

Describe the bug and reproduction steps

I created a review with comments for a PR. The comments were sensitive to the location in the code I placed them. E.g. one of them was: "Replace all this with [...]" and the location was multiple sections in the readme file. Then I triggered the resolver to address the comments. It did read the comments, but it does not seem to be aware of the comment locations. I suspect this for two reasons:

  1. The results were terrible with problems related to code locations.
  2. Looking at the log in the action, I could find the comments listed but there was no location attached to them.

OpenHands Installation

GitHub resolver

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

Tim-Pohlmann avatar Apr 16 '25 09:04 Tim-Pohlmann

The problem is how the resolver action loads the comments. The log for Attempt to resolve issue looks something like this:

08:44:55 - openhands:INFO: resolve_issue.py:230 - **MessageAction** (source=EventSource.USER)
CONTENT: The current code is an attempt at fixing one or more issues. The code is not satisfactory and follow up feedback have been provided to address this.
The feedback may be addressed to specific code files. In this case the file locations will be provided.
Please update the code based on the feedback for the repository in /workspace.
An environment has been set up for you to start working. You may assume all necessary tools are installed.

# Issues addressed
None

# Review comments
[
    "Review 1"
]

# Review threads
[
    "latest feedback:\nRemove all this and replace it with two CTAs to play the game.\n"
]

# Review thread files
[
    "README.md"
]

As you can see, only the file name is provided.

Tim-Pohlmann avatar Apr 16 '25 11:04 Tim-Pohlmann

I'm surprised, I thought the agent has location. In fact, ah maybe this is happening: it's possible to call it by tagging the name (@ openhands-agent) right at the location in the source file, and in that case I think it gets the location...

enyst avatar Apr 16 '25 12:04 enyst

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar May 17 '25 02:05 github-actions[bot]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 17 '25 02:06 github-actions[bot]

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 02 '25 02:08 github-actions[bot]

This issue was automatically closed due to 50 days of inactivity. We do this to help keep the issues somewhat manageable and focus on active issues.

github-actions[bot] avatar Aug 13 '25 02:08 github-actions[bot]