OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

Add strict mypy checking

Open neubig opened this issue 11 months ago • 2 comments

Make mypy checking more strict.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:78c89a3-nikolaik   --name openhands-app-78c89a3   docker.all-hands.dev/all-hands-ai/openhands:78c89a3

neubig avatar Jan 21 '25 19:01 neubig

Generally happy to see this change and if I can be of help chipping away at some of the fixes let me know.

I haven't tried them but there are various reports mypy can run on the thoroughness of type coverage, might be worth a look if not already using.

raymyers avatar Jan 22 '25 16:01 raymyers

@neubig a gentle ping in case this fell off your radar.

mamoodi avatar Feb 03 '25 15:02 mamoodi

I'm going to abandon this because we have more important priorities.

neubig avatar Jun 03 '25 21:06 neubig