[Bug]: "End Session" doesn't actually end the session
Is there an existing issue for the same bug?
- [X] I have checked the existing issues.
Describe the bug and reproduction steps
When switching models in the settings window, the following question gets asked:
End Session
Changing your settings will clear your workspace and start a new session. Are you sure you want to continue?
Clicking "End Session" takes me back to the home screen. The issue here is that the old Docker agents are actually still running
root@debian:~# docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
48007a0027e6 ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei "/openhands/micromam…" 9 minutes ago Up 9 minutes openhands-runtime-e0e1b6c0aa2b48a6a69ba48de827a897
f103c4b04e99 ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei "/openhands/micromam…" 11 minutes ago Up 11 minutes openhands-runtime-66abac90803a478f849a188f965ac727
d0b2bd6cbd36 ghcr.io/all-hands-ai/runtime:oh_v0.19.0_j4hs5zx4rwi2w13x_diqd851mcbpmq2ei "/openhands/micromam…" 24 minutes ago Up 24 minutes openhands-runtime-26c39a0900a241db89b6f9f08ff95812
Creating/opening a project starts yet another agent, burning resources.
I found this out when I was investigating why my usage credits on a popular LLM provider kept increasing. It turns out one of those containers were still working when I thought it was already ended.
OpenHands Installation
Development workflow
OpenHands Version
main
Operating System
None
Logs, Errors, Screenshots, and Additional Context
The problem here is the message that appears. We actually don't want the session to end because of the multi conversation feature that is in the works.
@rbren or @amanape should we change the message that appears or remove it altogether?
Start New Session Changes to your settings will only apply to new sessions. How would you like to continue?
- Create New Session
- Cancel
Maybe a small disclaimer as well while the multi-session feature is still being developed.
Yeah that's definitely a more accurate message. I'll let the folks I tagged chime in.
I think we should just change this text to
Changes to your settings will only affect new or resurrected conversations. Running conversations will be unaffected.
And not have any warning when you click "save"
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.
This behavior has changed now with 0.25 with the new multi conversation UI and this issue is no longer applicable.