All-Hands-AI
Fix s3 bucket reference
The FILE_STORE_PATH is always set and if S3 is the FILE_STORE type then FILE_STORE_PATH will have the S3 bucket name. There is no need for a separate S3 bucket variable.
Hmm it feels weird to reuse FILE_STORE_PATH for a bucket name. Is there another way to fix the issue here?
If we rename the setting, it affects user installations, it invalidates what they set. I'm not sure about this, sorry. It's alleviated by the fact that docker app users only use it since recently, but on the other hand it broke, and it would break again. 🤔
It seems with this solution, we still use a AWS_S3_BUCKET var, and a FILE_STORE_BUCKET var as well?
TBH I don't think anyone is using ~~this~~ the S3 integration, and I'm ok with breaking changes in 0.x. We'll document it in the changelog
@chuckbutkus can you fill out the normal PR template so we have a changelog entry?
Oh actually I do think FILE_STORE_PATH is used frequently--that'd be good to keep backward-compat
@mamoodi, yes, these changes are needed for OH to work on AWS. I just didn't get a chance to test them before I was pulled in another direction. I'm back on the AWS deploy now so I'll be testing shortly.
@mamoodi @rbren, I've created a new PR for these changes (https://github.com/All-Hands-AI/OpenHands/pull/6299) as this one was far enough behind the main branch that merging in main was causing problems. I'll close this one.
These changes have been moved to: https://github.com/All-Hands-AI/OpenHands/pull/6299