OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard
verified publisher icon All-Hands-AI

Upgrade `openhands-aci` to v0.1.2

Open ryanhoangt opened this issue 1 year ago • 3 comments

End-user friendly description of the problem this fixes or functionality that this introduces

  • [ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

This PR is to:

  • Upgrade openhands-aci to v0.1.2 with some bug fixes and a minor addition: https://github.com/All-Hands-AI/openhands-aci/releases/tag/0.1.2

Cc: @xingyaoww

Link of any specific issues this addresses

Close https://github.com/All-Hands-AI/OpenHands/issues/5365

ryanhoangt avatar Dec 04 '24 04:12 ryanhoangt

It will be interesting to see the results of the line numbers in edit change!

enyst avatar Dec 04 '24 04:12 enyst

@ryanhoangt there's an additional tests you might need to fix

xingyaoww avatar Dec 04 '24 04:12 xingyaoww

Hmm... Now the regex parsing causes the test with ipython code containing multiple file_editor calls fail: https://github.com/All-Hands-AI/OpenHands/blob/9908e1b28525fe96394446be95fcb00785d0ca0c/tests/runtime/test_ipython.py#L278-L290

ryanhoangt avatar Dec 04 '24 05:12 ryanhoangt

Running a 30 instance eval on this...Results will be posted automatically

mamoodi avatar Dec 04 '24 15:12 mamoodi

Oh dang....looks like because your repo is called OpenDevin, can't use the eval pipeline because of a bug. I'll have to come back to this in a bit. CC: @xingyaoww

EDIT: Let me try something.

mamoodi avatar Dec 04 '24 16:12 mamoodi

Evaluation results: ## Summary

  • submitted instances: 30
  • empty patch instances: 1
  • resolved instances: 14
  • unresolved instances: 16
  • error instances: 0

openhands-agent avatar Dec 04 '24 17:12 openhands-agent

Eval number looks reasonable! Let's merge it then

xingyaoww avatar Dec 04 '24 17:12 xingyaoww

@ryanhoangt I suggest updating your remote repository and forking the new OpenHands :D Just in case other weird things happen.

mamoodi avatar Dec 04 '24 17:12 mamoodi

Yep sounds good, I can do that!

ryanhoangt avatar Dec 04 '24 17:12 ryanhoangt

EDIT: Let me try something.

...What you tried, did work, right? (my repo is called playground 😹)

enyst avatar Dec 04 '24 18:12 enyst

Yes @enyst it worked lol so it's not that important. I have a bug fix for it. Shouldn't be too hard. I just remember my OpenDevin repo starting to act weird when we changed names but that may be an entirely different thing.

Running forks for now is a little more manual but as you mentioned, it works.

mamoodi avatar Dec 04 '24 18:12 mamoodi