OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

OpenHands UI should pop up a dialog box to warn before closing when agent is running

Open openhands-agent opened this issue 1 year ago • 3 comments

What problem or use case are you trying to solve?

If you have OpenHands open in a tab, it is easy to accidentally close it and lose the agent's progress if you close it while the agent is running.

Describe the UX of the solution you'd like

It would be good if the window popped up a dialog box warning the user before this happens.

Do you have thoughts on the technical implementation?

We can have an option in the frontend, on by default, that will pop up a dialog box. This will warn the user that the agent's work will be terminated and possibly lost if they close the window.

It can have three options:

  • always: always pop up the dialog box
  • while_working: pop up only while the agent is working, not when it's stopped
  • never: never pop up the dialog box

openhands-agent avatar Nov 28 '24 16:11 openhands-agent

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Nov 28 '24 16:11 github-actions[bot]

Sorry, this was me again...

neubig avatar Nov 28 '24 16:11 neubig

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-5315' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

github-actions[bot] avatar Nov 28 '24 16:11 github-actions[bot]

@neubig is this still something we want to do? I believe this will no longer be needed with multi convos.

mamoodi avatar Jan 06 '25 16:01 mamoodi

This is no longer required because of multi conversation support.

mamoodi avatar Jan 07 '25 22:01 mamoodi

Agreed

neubig avatar Jan 08 '25 00:01 neubig