OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard
verified publisher icon All-Hands-AI

Use i18n Keys

Open Vaishakh-SM opened this issue 1 year ago • 2 comments

End-user friendly description of the problem this fixes or functionality that this introduces

Right now, several instances of plain English language are used in the codebase. Using i18 keys would ensure better inclusivity by enabling users to use different languages.

Link of any specific issues this addresses

Issue#4280

Vaishakh-SM avatar Nov 26 '24 17:11 Vaishakh-SM

@amanape , as mentioned here, the tests are failing since I've changed hard-coded alt-text values. Should I update the tests in this PR?

Vaishakh-SM avatar Dec 03 '24 16:12 Vaishakh-SM

Feel free to do so. I think I'll be able to resolve the conflicts myself later this week (apparently I should be able to resolve them 😅)

amanape avatar Dec 03 '24 16:12 amanape

@amanape , I think OpenHands was able to clean this up, please TAL!

neubig avatar Dec 11 '24 16:12 neubig

@amanape any chance you have a few minutes to review this PR please?

mamoodi avatar Dec 23 '24 14:12 mamoodi

@Vaishakh-SM just needs a final conflict resolution for merge if you have a few minutes 🙏

mamoodi avatar Dec 30 '24 15:12 mamoodi