OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

[Bug]: Github Resolver comment "workflow error" when the workflow is successful

Open xingyaoww opened this issue 1 year ago • 3 comments

Is there an existing issue for the same bug?

  • [X] I have checked the existing issues.

Describe the bug and reproduction steps

Example: https://github.com/All-Hands-AI/OpenHands/pull/5181#issuecomment-2494766867

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

Error log:

The workflow to fix this issue encountered an error. Please check the workflow logs for more information.

xingyaoww avatar Nov 22 '24 20:11 xingyaoww

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Nov 22 '24 20:11 github-actions[bot]

I've found one issue which was introduced in this PR

~~target-branch parameter was added to the Attempt to resolve issue step instead of Create draft PR or push branch step in .github/workflows/openhands-resolver.yml~~

EDIT: target-branch paramater was introduced in the openhands-ai package which has not been released as of yet. The changes in .github/workflows/openhands-resolver.yml require the unreleased version of openhands-ai

I think there may be one more bug, will keep digging

malhotra5 avatar Nov 22 '24 22:11 malhotra5

The issue I linked looks like a duplicate of this. If you can confirm that, @malhotra5 , I'll just close it.

Example run where it clearly did everything right, just the JSON parsing says it was wrong, apparently: https://github.com/All-Hands-AI/OpenHands/pull/5242#issuecomment-2496496749

enyst avatar Nov 25 '24 01:11 enyst

Hmm I don't think its a duplicate. This issue was a more severe case of the resolver failing midway through the workflow, which should be resolved now. Let's close this one and track the JSON decoding issues in #5234.

malhotra5 avatar Dec 01 '24 18:12 malhotra5