OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

Simon custom

Open chensihai opened this issue 1 year ago • 1 comments

These code solve few problems 1)Refactor the code, create backend folder; more clear architecture for codes 2)support docker-compose up -d to bring up the whole stack, and the meantime, keep the existing way work 3)Get off Sandbox for docker-compose way only, the existing way still use Sandbox if(AM_I_IN_A_DOCKER_CONTAINER == "Yes"): from .command_manager_without_sandbox import CommandManager else:
from .command_manager import CommandManager

chensihai avatar Apr 01 '24 03:04 chensihai

@chensihai thanks for the PR!

I think this will be easier to review/merge if we split it up, especially the move to the backend/ folder.

Very excited to have a working docker-compose up! The sandbox switch makes sense, though I think eventually having docker-in-docker will be more consistent, and lead to less maintenance overhead.

Seems like there are a lot of merge issues--several files have gotten reworked/deleted.

rbren avatar Apr 01 '24 14:04 rbren