OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

[Bug]: Reduce padding in lists inside of messages

Open rbren opened this issue 1 year ago • 15 comments

Is there an existing issue for the same bug?

  • [X] I have checked the troubleshooting document at https://docs.all-hands.dev/modules/usage/troubleshooting
  • [X] I have checked the existing issues.

Describe the bug

The spacing here is a little over the top :) Screenshot 2024-09-27 at 10 39 35 AM

This can probably be fixed by modifying the spacing in frontend/src/index.css

Current OpenHands version

0.9.5

Installation and Configuration

`docker run` from the README

Model and Agent

N/A

Operating System

N/A

Reproduction Steps

Write a prompt that uses markdown bullet points

Logs, Errors, Screenshots, and Additional Context

No response

rbren avatar Sep 27 '24 14:09 rbren

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Sep 28 '24 05:09 github-actions[bot]

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Sep 28 '24 05:09 github-actions[bot]

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named '' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

github-actions[bot] avatar Sep 28 '24 05:09 github-actions[bot]

Attempting to fix this PR automatically uncovered two issues:

  • https://github.com/All-Hands-AI/OpenHands/issues/4103
  • https://github.com/All-Hands-AI/openhands-resolver/issues/111

neubig avatar Sep 28 '24 06:09 neubig

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Sep 28 '24 12:09 github-actions[bot]

A potential fix has been generated and a draft PR # has been created. Please review the changes.

github-actions[bot] avatar Sep 28 '24 12:09 github-actions[bot]

Sorry, the message above is incorrect: https://github.com/All-Hands-AI/openhands-resolver/issues/117

I'll fix the resolver and try again.

neubig avatar Sep 28 '24 13:09 neubig

OpenHands started fixing the issue! You can monitor the progress here.

github-actions[bot] avatar Sep 28 '24 15:09 github-actions[bot]

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-4082-try2' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

github-actions[bot] avatar Sep 28 '24 15:09 github-actions[bot]

Hi! Can I work on this?

Vaishakh-SM avatar Oct 02 '24 13:10 Vaishakh-SM

Yes, please go ahead @Vaishakh-SM !

neubig avatar Oct 02 '24 13:10 neubig

Adding a checklist of items that I intend to complete as a part of this task:

  • [x] Dev Setup efforts (Following the guide)
  • [x] Reproduction of the issue
  • [x] Glance over the frontend code-base, particularly places related to styling.
  • [x] Tweak styling and check if the issue is resolved
  • [x] Raise PR

Vaishakh-SM avatar Oct 02 '24 14:10 Vaishakh-SM

Hey @Vaishakh-SM please have a look at #3449 and the comment by @amanape I never got to do the follow PR. The above should give you a good starting point where to look, I hope.

tobitege avatar Oct 02 '24 14:10 tobitege

Hey @Vaishakh-SM please have a look at #3449 and the comment by @amanape I never got to do the follow PR.

Thanks, this helps a lot!

Can I remove the styles that you added to index.css if I add them into the Markdown component like:

      <Markdown
        components={{
          code,
          ul: ({ children }) => (
            <ul className="list-decimal ml-5 pl-2">{children}</ul>
          ),
          ol: ({ children }) => (
            <ol className="list-disc ml-5 pl-2">{children}</ol>
          ),
        }}
      >

Vaishakh-SM avatar Oct 02 '24 15:10 Vaishakh-SM

Sure :)

tobitege avatar Oct 02 '24 15:10 tobitege