OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

feat: Always mount a Docker volume to use as workspace instead of host's disk

Open amanape opened this issue 1 year ago • 4 comments

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG This PR will attempt to accomplish:

  • No mounting to host disk by default
  • Instead, an option to use host disk should be available (in case existing users would prefer it)

Give a summary of what the PR does, explaining any non-trivial design decisions Creates a volume (if one does not already exist) and mounts it instead of the host disk.


TODO

  • [ ] Allow the user to set host disk as volume
  • [ ] Clear/delete volume on new session

amanape avatar Sep 20 '24 11:09 amanape

I like the idea of a configurable volume to mount, as an option.

What is the reasoning to make this PR's approach the new, default behavior?

tobitege avatar Sep 20 '24 11:09 tobitege

Stephan is working through a new default user flow that would avoid mounting by default (to avoid all the file permission and mounting issues we've seen). Instead, we'd nudge the user toward pushing/pulling from GitHub, or uploading/downloading files via the UI

rbren avatar Sep 20 '24 15:09 rbren

Stephan is working through a new default user flow that would avoid mounting by default (to avoid all the file permission and mounting issues we've seen). Instead, we'd nudge the user toward pushing/pulling from GitHub, or uploading/downloading files via the UI

But the current mounting way will still be available then as an option, right?

tobitege avatar Sep 20 '24 15:09 tobitege

Yup!

rbren avatar Sep 20 '24 15:09 rbren

Outdated

amanape avatar Oct 10 '24 16:10 amanape