OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

Add attach file button to chat input

Open AbhisekOmkar opened this issue 1 year ago • 7 comments

Introduce an SVG-based attach file button to allow users to add attachments to their messages.

  • Adjust input field and send button styling to accommodate the new button.
  • Enhance user interaction by providing a clear visual cue for attaching files. Screenshot 2024-03-16 at 10 54 43 PM

AbhisekOmkar avatar Mar 16 '24 17:03 AbhisekOmkar

Sure, I understand your request. I will make sure to limit the changes in the PR to only those related to the main topic and avoid including formatting changes. Thank you for bringing this to my attention, and I'll ensure the PR focuses solely on the intended modifications.

AbhisekOmkar avatar Mar 17 '24 06:03 AbhisekOmkar

@huybery can you merge it

AbhisekOmkar avatar Mar 17 '24 11:03 AbhisekOmkar

@huybery can you merge it

Sry, I still need @neubig Graham to take a final look. Me and @huybery do not have expertise in this field. Apparently I think you have fixed the formatting issue but I am not so sure about this.

JustinLin610 avatar Mar 17 '24 15:03 JustinLin610

@huybery can you merge it

Sry, I still need @neubig Graham to take a final look. Me and @huybery do not have expertise in this field. Apparently I think you have fixed the formatting issue but I am not so sure about this.

I have checked the this on my local machine its working as expected and i have attached screenshot as well.

AbhisekOmkar avatar Mar 17 '24 15:03 AbhisekOmkar

I'll take a look but might not have time till tomorrow!

neubig avatar Mar 17 '24 15:03 neubig

Hi @AbhisekOmkar , thanks so much again for the patience!

We just merged in some linting/formatting stuff that will standardize our formatting and make this PR easier to review. Could you please git pull origin main to merge in these changes, fix any merge conflicts, and I'll review after that?

neubig avatar Mar 17 '24 18:03 neubig

@neubig Its done now

AbhisekOmkar avatar Mar 18 '24 19:03 AbhisekOmkar

Im closing the PR seems to be some issues in the local machine

AbhisekOmkar avatar Mar 19 '24 07:03 AbhisekOmkar