OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

[Bug]: Edit command sometimes hangs

Open li-boxuan opened this issue 1 year ago • 4 comments

Is there an existing issue for the same bug?

  • [X] I have checked the troubleshooting document at https://opendevin.github.io/OpenDevin/modules/usage/troubleshooting
  • [X] I have checked the existing issues.

Describe the bug

image

You cannot really tell from the screenshot above, but I promise it hangs.

Current Version

commit 09e8b114516da1ba51e9f2f171f183e166cd3962 (HEAD -> main, upstream/main)
Author: Robert Brennan <[email protected]>
Date:   Wed May 8 22:56:33 2024 -0400

Installation and Configuration

I was using sandbox directly, but this can be easily reproduced using any task that involves 'edit' command.

Model and Agent

Agent: CodeActAgent

Reproduction Steps

No response

Logs, Errors, Screenshots, and Additional Context

@xingyaoww has a hack in https://github.com/OpenDevin/OpenDevin/pull/1612 for mitigation.

Let's use this issue to track the root cause analysis and real fix.

li-boxuan avatar May 09 '24 07:05 li-boxuan

FWIW this is why it hangs - read -r line doesn't read anything. Why? I don't know.

https://github.com/OpenDevin/OpenDevin/blob/73e180638e9ebadb0f6d99218cafb169fffcd2b6/opendevin/runtime/plugins/swe_agent_commands/edit_linting.sh#L55-L59

li-boxuan avatar May 09 '24 07:05 li-boxuan

@xingyaoww I don't think https://github.com/OpenDevin/OpenDevin/pull/1612 fixed this unfortunately--I was seeing it on main this morning

rbren avatar May 10 '24 02:05 rbren

It worked for me - at least for a single edit, the hack worked.

Get Outlook for iOShttps://aka.ms/o0ukef


From: Robert Brennan @.> Sent: Thursday, May 9, 2024 7:26:21 PM To: OpenDevin/OpenDevin @.> Cc: Author @.>; Comment @.> Subject: Re: [OpenDevin/OpenDevin] [Bug]: Edit command sometimes hangs (Issue #1663)

@xingyaowwhttps://github.com/xingyaoww I don't think #1612https://github.com/OpenDevin/OpenDevin/pull/1612 fixed this unfortunately--I was seeing it on main this morning

— Reply to this email directly, view it on GitHubhttps://github.com/OpenDevin/OpenDevin/issues/1663#issuecomment-2103745361 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGENUWWF75S34CIOVUMG7K3ZBQV45BFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVI3DMOBUGM4DOOJXGKSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWG44DQMRSGM3TINFENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTONZRGMYDEMBYGOBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZDQNZQHA4TSNRQQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRWGY4DIMZYG44TOMUCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRXHA4DEMRTG42DJJ3UOJUWOZ3FOKTGG4TFMF2GK. You are receiving this email because you authored the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

li-boxuan avatar May 10 '24 02:05 li-boxuan

Downgraded severity as we have a workaround in-place.

li-boxuan avatar May 11 '24 23:05 li-boxuan

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 11 '24 01:06 github-actions[bot]

This issue was closed because it has been stalled for over 30 days with no activity.

github-actions[bot] avatar Jun 18 '24 01:06 github-actions[bot]

This should already be fixed in recent Python agentskills refractor.

xingyaoww avatar Jun 18 '24 02:06 xingyaoww