Fix browser env leak after resetting agent
Fixes #1528
Codecov Report
Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
main@a60a6a4). Click here to learn what that means.
| Files | Patch % | Lines |
|---|---|---|
| opendevin/runtime/browser/browser_env.py | 0.00% | 12 Missing :warning: |
| opendevin/controller/agent_controller.py | 0.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## main #1589 +/- ##
=======================================
Coverage ? 61.72%
=======================================
Files ? 92
Lines ? 3767
Branches ? 0
=======================================
Hits ? 2325
Misses ? 1442
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@frankxu2004 you can probably move this into agent_controller.close() now
Looking good! I think we just need to add a close() call into agent_controller
Added and tested that now after agent re-init (e.g. change config), the browser process will always shutdown correctly. Should be ready @rbren
Thanks Frank!