OpenHands icon indicating copy to clipboard operation
OpenHands copied to clipboard

Mentioned LLM logs directory

Open SmartManoj opened this issue 1 year ago • 4 comments

Helpful for issues like #1578

SmartManoj avatar May 05 '24 05:05 SmartManoj

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@a60a6a4). Click here to learn what that means.

Files Patch % Lines
opendevin/core/logger.py 57.14% 3 Missing :warning:
opendevin/core/config.py 85.71% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1587   +/-   ##
=======================================
  Coverage        ?   61.71%           
=======================================
  Files           ?       92           
  Lines           ?     3766           
  Branches        ?        0           
=======================================
  Hits            ?     2324           
  Misses          ?     1442           
  Partials        ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 05 '24 05:05 codecov-commenter

@enyst Debug env is not needed for this. It's used in JupyterKernel only 4768f6f

SmartManoj avatar May 05 '24 05:05 SmartManoj

Ah, maybe that got messed up, a check for it when setting level should do it. The problem if everyone gets it by default is that the number of files becomes so large so fast. Users probably shouldn't have it happen on their machine IMHO, absent some specific intention. Although... they're so handy. 😅

enyst avatar May 05 '24 09:05 enyst

Thanks! This will be helpful

rbren avatar May 06 '24 12:05 rbren

@SmartManoj looks like you just need to fix the conflict. @enyst would you rather this PR reverts the config stuff, so we can take care of it in your PR?

rbren avatar May 09 '24 15:05 rbren

@rbren Fixed.

SmartManoj avatar May 09 '24 15:05 SmartManoj

Merging! @enyst if there are conflicts, you can probably just git checkout --ours to blow out these changes and go w/ your own

rbren avatar May 09 '24 17:05 rbren