terway icon indicating copy to clipboard operation
terway copied to clipboard

feat(eni): add selection policy

Open exherb opened this issue 1 year ago • 5 comments

exherb avatar May 28 '24 03:05 exherb

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.67%. Comparing base (498d2c3) to head (781da2e).

Files Patch % Lines
pkg/eni/manager.go 58.33% 5 Missing :warning:
daemon/config.go 75.00% 2 Missing :warning:
daemon/daemon.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   23.42%   23.67%   +0.25%     
==========================================
  Files          62       62              
  Lines        6477     6491      +14     
==========================================
+ Hits         1517     1537      +20     
+ Misses       4717     4710       -7     
- Partials      243      244       +1     
Flag Coverage Δ
unittests 23.67% <61.90%> (+0.25%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 28 '24 03:05 codecov[bot]

@exherb go test failed

l1b0k avatar Jun 05 '24 01:06 l1b0k

@exherb go test failed

I will fix it

exherb avatar Jun 15 '24 01:06 exherb

@l1b0k 测试应该能过了, 不过不知道为啥测试没跑

exherb avatar Jun 17 '24 06:06 exherb

@l1b0k please review again, sorry for the delay.

exherb avatar Jul 03 '24 09:07 exherb

@exherb Thanks for your contribution.

l1b0k avatar Jul 04 '24 08:07 l1b0k