html2text icon indicating copy to clipboard operation
html2text copied to clipboard

`None` link title assert hit

Open equaeghe opened this issue 4 years ago • 10 comments

There is the following in the code:

https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/init.py#L781

Of course someone managed to produce html with links of the form <a title href="example.org">…</a> that trigger this assert. I think better than having the assert would be to replace

https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/init.py#L780

with

link_attrs_title = link.attrs.get("title", None)
if link_attrs_title is not None:

N.B.: The same type of pattern fixable in the way can be found on three other occasions:

  • https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/init.py#L502
  • https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/init.py#L514
  • https://github.com/Alir3z4/html2text/blob/24aac8629f6a50ab262727815107384e0682cf42/html2text/init.py#L517

equaeghe avatar Jun 15 '20 09:06 equaeghe