Bookkeeping
Bookkeeping copied to clipboard
[O2B-1217] Calculate QC flags effective periods
I have a JIRA ticket
- [x] branch and/or PR name(s) include(s) JIRA ID
- [ ] issue has "Fix version" assigned
- [ ] issue "Status" is set to "In review"
- [x] PR labels are selected
Notable changes for users:
- NA
Notable changes for developers:
- Added calculation of QC flag part which was no discarded by newer flag
- Refactored QC flags adapters
Changes made to the database:
- NA
Codecov Report
Attention: Patch coverage is 93.22034% with 4 lines in your changes are missing coverage. Please review.
Project coverage is 43.63%. Comparing base (
ec13a04) to head (6d52a6c).
| Files | Patch % | Lines |
|---|---|---|
| ...erver/services/qualityControlFlag/QcFlagService.js | 91.66% | 3 Missing :warning: |
| lib/database/repositories/Repository.js | 88.88% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1533 +/- ##
==========================================
+ Coverage 43.42% 43.63% +0.20%
==========================================
Files 835 837 +2
Lines 14040 14098 +58
Branches 2495 2505 +10
==========================================
+ Hits 6097 6151 +54
- Misses 7943 7947 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.