Bookkeeping icon indicating copy to clipboard operation
Bookkeeping copied to clipboard

[O2B-1194] Refactor export functionality

Open xsalonx opened this issue 1 year ago • 1 comments

I have a JIRA ticket

  • [x] branch and/or PR name(s) include(s) JIRA ID
  • [x] issue has "Fix version" assigned
  • [x] issue "Status" is set to "In review"
  • [x] PR labels are selected

Notable changes for users:

  • Changed export functionality:
    • Allow to input file name
    • Use spinner to show data are being loaded

Notable changes for developers:

  • Extracted export-related methods to OverviewPageModel
  • Generalised exportTriggerAndModal to work with another overview views

Changes made to the database:

  • NA

xsalonx avatar Mar 14 '24 09:03 xsalonx

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 45.20%. Comparing base (24ddf8b) to head (3536cf7). Report is 358 commits behind head on main.

Files Patch % Lines
lib/public/models/OverviewModel.js 0.00% 53 Missing :warning:
...ublic/views/Runs/Overview/exportTriggerAndModal.js 0.00% 32 Missing :warning:
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1462      +/-   ##
==========================================
- Coverage   48.78%   45.20%   -3.58%     
==========================================
  Files         528      768     +240     
  Lines        7968    12452    +4484     
  Branches     1477     2220     +743     
==========================================
+ Hits         3887     5629    +1742     
- Misses       4081     6823    +2742     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 14 '24 10:03 codecov[bot]