AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

DPL: drop all messages when cleanup property increases

Open ktf opened this issue 2 years ago • 9 comments

This is an attempt at doing what we discussed. Frankly speaking I am more and more convinced this is a hack (if it works at all) and we should either have a proper DRAIN state, or we discard messages based on the run number.

ktf avatar Aug 26 '22 12:08 ktf

What is the problem with this? actually looks quite straight-forward

davidrohr avatar Aug 26 '22 12:08 davidrohr

First of all, it's not clear to me how doing something in Subscribe() will avoid the state machine to advance. Properties are notified from a separate thread and the mutex is released before the callback is invoked. Secondly, it relies on the fact that Receive returns 0 parts, but there is no way I can know if they are really 0, or it just happened to be 0. If this works reliably, there is something I do not understand.

ktf avatar Aug 26 '22 12:08 ktf

Error while checking build/O2/o2-dataflow for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 20:37:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc7_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc7_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Aug 31 '22 13:08 alibuild

Error while checking build/O2/o2 for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 20:40:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc7_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc7_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 01 '22 14:09 alibuild

Error while checking build/AliceO2/O2/o2/macOS-arm for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 20:08:

## sw/BUILD/O2-latest/log
/System/Volumes/Data/build/alice-ci-workdir/o2/sw/SOURCES/O2/9704/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: use of undeclared identifier 'mDeviceContext'
/System/Volumes/Data/build/alice-ci-workdir/o2/sw/SOURCES/O2/9704/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: use of undeclared identifier 'deviceContext'
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 03 '22 18:09 alibuild

Error while checking build/O2/o2-dataflow-cs8 for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-23 01:26:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 03 '22 19:09 alibuild

Error while checking build/O2/o2-cs8 for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 19:40:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 03 '22 20:09 alibuild

Error while checking build/O2/fullCI for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 20:52:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 06 '22 08:09 alibuild

Error while checking build/AliceO2/O2/o2/macOS for cccc8ff37ee01c45568499b9af807d25308ce719 at 2022-10-22 21:18:

## sw/BUILD/O2-latest/log
/System/Volumes/Data/build/alice-ci-workdir/o2/sw/SOURCES/O2/9704/0/Framework/Core/src/DataProcessingDevice.cxx:156:95: error: use of undeclared identifier 'mDeviceContext'
/System/Volumes/Data/build/alice-ci-workdir/o2/sw/SOURCES/O2/9704/0/Framework/Core/src/DataProcessingDevice.cxx:163:25: error: use of undeclared identifier 'deviceContext'
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Sep 08 '22 19:09 alibuild

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Nov 22 '22 01:11 github-actions[bot]

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Dec 23 '22 01:12 github-actions[bot]

Error while checking build/O2/fullCI for 1b91241c88cd7ce425b53f2280f3c48f4666db43 at 2023-02-22 16:54:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:128:95: error: 'mDeviceContext' was not declared in this scope; did you mean 'DeviceContext'?
/sw/SOURCES/O2/9704-slc8_x86-64/0/Framework/Core/src/DataProcessingDevice.cxx:135:25: error: 'deviceContext' was not declared in this scope; did you mean 'DeviceContext'?
ninja: build stopped: subcommand failed.

Full log here.

alibuild avatar Feb 22 '23 15:02 alibuild