AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

O2_GENERATE_DICTIONARY problem when Headers are not set explicitely

Open sawenzel opened this issue 7 years ago • 7 comments

I ran into the following problem:

a) I do not set HEADERS explicitely in my cmake b) I set LINKDEF to some LinkDef.h

Since HEADERS are not set, O2_GENERATE_LIBRARY will search for HEADERS itself and picks up LinkDef.h. This leads to errors with rootcling because "LinkDef.h" will appear twice.

I think we need to protect against this in some way. Possibly just checking if the LINKDEF file is also present in the HEADERS list.

sawenzel avatar Mar 03 '17 09:03 sawenzel

You are correct. I'll have a look.

Barthelemy avatar Mar 03 '17 11:03 Barthelemy

Is this done?

ktf avatar Dec 13 '17 22:12 ktf

no. I will move it to JIRA where I will be able to see it and organize it with the rest of my work. How can I close this one ? There is no close button.

Barthelemy avatar Dec 14 '17 08:12 Barthelemy

https://alice.its.cern.ch/jira/browse/OCCF-46

Barthelemy avatar Dec 14 '17 08:12 Barthelemy

@Barthelemy: I think the issue should stay open here in parallel. Otherwise, it is hard to track progress and know when it was done ...

sawenzel avatar Dec 14 '17 08:12 sawenzel

@sawenzel I understand your point. At the same time, I fear that it will quickly become unmanageable. I will keep it opened for now but would like to rediscuss it with you after Christmas, maybe around a coffee.

Barthelemy avatar Dec 14 '17 08:12 Barthelemy

Agreed.

sawenzel avatar Dec 14 '17 08:12 sawenzel