AliceO2 icon indicating copy to clipboard operation
AliceO2 copied to clipboard

Default TPC loopers in o2-sim

Open jackal1-66 opened this issue 1 month ago • 4 comments

TPC loopers are currently injected via an O2DPG external generator by creating a cocktail. This development feeds them automatically in case the TPC detector is used and transported. A collisioncontext.root file is mandatory, otherwise the loopers will be automatically turned off. In addition the GenTPCLoopers.loopersVeto parameter has been introduced to forcefully turn off the injection. This PR is linked to https://github.com/AliceO2Group/O2DPG/pull/2191, in which the collision system is automatically fed to the sgnsim step

jackal1-66 avatar Nov 25 '25 07:11 jackal1-66

REQUEST FOR PRODUCTION RELEASES: To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available async-2023-pbpb-apass4 async-2023-pp-apass4 async-2024-pp-apass1 async-2022-pp-apass7 async-2024-pp-cpass0 async-2024-PbPb-apass1 async-2024-ppRef-apass1 async-2024-PbPb-apass2 async-2023-PbPb-apass5

github-actions[bot] avatar Nov 25 '25 07:11 github-actions[bot]

Error while checking build/O2/fullCI_slc9 for 797f283e8954fccb52e2854d31eecfe4d480254e at 2025-11-25 09:12:

## sw/BUILD/O2-latest/log
CMake Error at cmake/AddRootDictionary.cmake:91 (message):

Full log here.

alibuild avatar Nov 25 '25 08:11 alibuild

Error while checking build/O2/fullCI_slc9 for 76f999637a7bdff042d39635db039efdb4c56337 at 2025-12-03 15:26:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14851-slc9_x86-64/0/Generators/src/TPCLoopers.cxx:49:30: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14851-slc9_x86-64/0/Generators/src/TPCLoopers.cxx:51:9: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14851-slc9_x86-64/0/Generators/src/TPCLoopers.cxx:83:20: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild avatar Nov 25 '25 13:11 alibuild

I implemented all the comments and retested the code.

jackal1-66 avatar Dec 03 '25 16:12 jackal1-66

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

github-actions[bot] avatar Jan 03 '26 01:01 github-actions[bot]

The failing CI is unrelated to this PR:

522/522 Test  #29: test_GPUsortCUDA .....................................................................***Failed    0.02 sec
Running 4 test cases...
ErrorCode 35 cudaErrorInsufficientDriver: CUDA driver version is insufficient for CUDA runtime version

@ktf @singiamtel could you please check what's wrong with that specific test? I see that it's failing in other PRs as well

jackal1-66 avatar Jan 05 '26 09:01 jackal1-66